-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GasFeePricingUpgradeable #158
Conversation
Pull Request Test Coverage Report for Build 2378229420
💛 - Coveralls |
|
||
event ChainInfoUpdated(uint256 indexed chainId, uint256 gasTokenPrice, uint256 gasUnitPrice); | ||
|
||
event MarkupsUpdated(uint256 markupGasDrop, uint256 markupGasUsage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a markup (might want to be a little more verbose here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- variable names should be more clear now - enforced alfabetical order of variables to avoid confusion - docs on the srtucts are more verbose - tests are updated to reflect the these changes
- wrong value was used to check for maxGasDrop - some values were not cast to uin256, resulting in overflows
More tests are needed, but the contracts should be pretty close to their final form. |
Closed in favor of #162 |
Description
This PR will make
GasFeePricing
upgradeable. It will also use messaging for cross-chain setups.Checklist